Check isnan in maximum / minimum with CPU backend#2652
Merged
awni merged 3 commits intoml-explore:mainfrom Nov 3, 2025
Merged
Conversation
Member
|
Could you add a test for this so we know it's working as expected? |
Contributor
Author
|
@aisk tests added. |
awni
reviewed
Oct 13, 2025
tests/ops_tests.cpp
Outdated
Comment on lines
+1065
to
+1070
| x = array({1.0f, NAN, 3.0f}); | ||
| auto y = array({NAN, 2.0f, 1.0f}); | ||
| auto max_result = maximum(x, y); | ||
| auto min_result = minimum(x, y); | ||
| CHECK(array_equal(max_result, array({NAN, NAN, 3.0f}), true).item<bool>()); | ||
| CHECK(array_equal(min_result, array({NAN, NAN, 1.0f}), true).item<bool>()); |
Member
There was a problem hiding this comment.
None of these tests will hit the simd implementation because it will only be used for 8 or more elements. So could you add a tests with larger vectors, say 8 or 16?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Please include a description of the problem or feature this PR is addressing. If there is a corresponding issue, include the issue #.
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes